> I would say the fact that there are no spaces in the code to separate the commas, the operators or anything, it is not the most readable code I would say.
>
> I think it is each and every coders responsibility to make sure their own code can be easily understood by other members of their team, working in a small team or by yourself really is no excuse. I've looked at code I wrote six, seven, more years ago and been annoyed at myself for not making it more readable, I think I constantly improve so look back at my old code and usually sigh.
>
> This type of parsing was necessary before more helpful functions became available but if written in VFP5 or 6 the coder could have split it up into more lines to help other people maintain it, it made my head hurt when I was trying to read it and that's never good.

Well to say the truth it took me less than a few seconds to see what the code was doing, it was perfectly readable, so I classify this one as good not bad. If one can see what the code is doing at a glance, I don't think it should matter to split into multiple lines (and actually he did, doing the operation in 2 steps).
Anyway it shows 'bad and good' code is also a relative thing and personal preference at times. OTOH I also classify as bad for not having mdot.

Cetin Basoz